Update: support qcs account headers on engagement creation#1438
Closed
erichulburd wants to merge 1 commit intorcfrom
Closed
Update: support qcs account headers on engagement creation#1438erichulburd wants to merge 1 commit intorcfrom
erichulburd wants to merge 1 commit intorcfrom
Conversation
1cfda88 to
679bcc2
Compare
dbanty
approved these changes
Apr 26, 2022
Contributor
dbanty
left a comment
There was a problem hiding this comment.
Looks good—my only comment is it seems like the new fields could belong on the config object which is already optionally passed into get_qc and the EngagementManager. Then we don't expand the get_qc signature which is already fairly complicated and the config continues to serve the purpose of modifying QCS calls.
679bcc2 to
868da1e
Compare
10 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We want to support the client's ability to explicitly set QCS account on the quantum computer they will execute against. To this end, we allow clients to explicitly pass
account_idandaccount_typeonget_qc. This will initialize anEngagementManagerwith account id/type, which, in turn, will set theX-QCS-ACCOUNT-{ID/TYPE}headers on the engagement request. This enables users to identify their QPU job as belonging to a group account.TODO:
Checklist
rcbranch (notmaster).flake8conventions.